This repository has been archived by the owner on Jul 10, 2024. It is now read-only.
[OBS-270] Use Postman LCA image locations #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgritter
approved these changes
Sep 13, 2023
cmd/internal/ecs/add.go
Outdated
| @@ -531,7 +530,7 @@ func getTaskState(wf *AddWorkflow) (nextState optionals.Optional[AddWorkflowStat | |||
| // Check that the Akita CLI is not already present | |||
| for _, container := range output.ContainerDefinitions { | |||
| image := aws.ToString(container.Image) | |||
| if matchesImage(image, akitaECRImage) || matchesImage(image, akitaDockerImage) { | |||
| if matchesImage(image, akitaECRImage) { | |||
There was a problem hiding this comment.
If I believed we had any existing users who were going to change, this would be a little concerning -- what we ought to do for robustness is check both old and new names to see whether the agent is installed in the task definition. But, the ECS onboarding flow did not get a lot of uptake.
There was a problem hiding this comment.
In 84300a7. Re-requesting review to make sure I understood what you meant.
mgritter
approved these changes
Sep 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.