Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPORT-774] Graphql data mode from curl import #67

Merged

Conversation

aman-v-singh
Copy link
Contributor

@aman-v-singh aman-v-singh commented Jun 20, 2023

Screen.Recording.2023-06-23.at.1.44.43.PM.mov

@aman-v-singh aman-v-singh marked this pull request as ready for review June 22, 2023 05:44
Copy link
Member

@VShingala VShingala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aman-v-singh Let's also add unit tests for the changes we have added here.

src/lib.js Show resolved Hide resolved
src/lib.js Outdated Show resolved Hide resolved
src/lib.js Outdated Show resolved Hide resolved
@aman-v-singh aman-v-singh self-assigned this Jun 23, 2023
src/lib.js Outdated Show resolved Hide resolved
src/lib.js Outdated Show resolved Hide resolved
src/lib.js Outdated Show resolved Hide resolved
Copy link
Member

@VShingala VShingala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few comments, also cURL snippet mentioned here is not getting imported correctly with track that you shared in postman app. i.e. body is selected as non in this case.

postmanlabs/postman-app-support#9941

@aman-v-singh
Copy link
Contributor Author

aman-v-singh commented Jun 26, 2023

Added few comments, also cURL snippet mentioned here is not getting imported correctly with track that you shared in postman app. i.e. body is selected as non in this case.

postmanlabs/postman-app-support#9941

@VShingala same error is happening in the default track. Will try to look for the issue.

src/lib.js Outdated Show resolved Hide resolved
src/lib.js Outdated Show resolved Hide resolved
src/lib.js Outdated Show resolved Hide resolved
src/lib.js Outdated Show resolved Hide resolved
@VShingala VShingala merged commit 9af9acc into develop Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants