Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce a feature flags to control the frequency of checks #56

Merged
merged 1 commit into from
Oct 26, 2022
Merged

introduce a feature flags to control the frequency of checks #56

merged 1 commit into from
Oct 26, 2022

Conversation

myaser
Copy link
Contributor

@myaser myaser commented Oct 26, 2022

#55

@coveralls
Copy link

coveralls commented Oct 26, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3330999052

  • 7 of 13 (53.85%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 77.718%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/kubenurse/server.go 7 13 53.85%
Totals Coverage Status
Change from base Build 3328142015: -0.7%
Covered Lines: 436
Relevant Lines: 561
💛 - Coveralls

@myaser myaser marked this pull request as ready for review October 26, 2022 14:43
@myaser myaser force-pushed the customizable-schedule branch from bfebe6d to 3598254 Compare October 26, 2022 17:00
@zbindenren
Copy link
Member

zbindenren commented Oct 26, 2022 •
edited
Loading

Thx for your contribution. Lgtm.

@zbindenren zbindenren merged commit d63aadd into postfinance:master Oct 26, 2022
@myaser
Copy link
Contributor Author

myaser commented Oct 27, 2022

Would you please issue a release with these changes?

@zbindenren
Copy link
Member

Currently a lot to do @ work. Try to update the helm chart and creating a new release next week.

@zbindenren
Copy link
Member

zbindenren commented Nov 1, 2022 •
edited
Loading

A new docker image is released: https://hub.docker.com/r/postfinance/kubenurse/tags

We will also update the helm chart to make it more configurable.

@myaser myaser deleted the customizable-schedule branch January 18, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@myaser @coveralls @zbindenren