fix: don't set spec.updateStrategy.maxSurge of DaemonSet by default #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin0u0
force-pushed
the
dont-set-daemonset-maxsurge-by-default
branch
from
d9822a8 to
2215b27
Compare
Pull Request Test Coverage Report for Build 11138571088Details
💛 - Coveralls |
…pdateStrategy.maxSurge Helm parameters
justin0u0
force-pushed
the
dont-set-daemonset-maxsurge-by-default
branch
from
2215b27 to
143a0e1
Compare
|
Thx for your contribution |
|
Hi @zbindenren, could you tag the latest commit for a new release? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋,
This PR fixes the Helm chart so that
spec.updateStrategy.maxSurgeis not set by default.The reason for this change is that in Kubernetes clusters older than version 1.25, the maxSurge field is unavailable unless the feature gate is enabled1.
On the other hand, Kubernetes' default behavior is to set maxSurge to 0 if the field is omitted2. Therefore, omitting this field should maintain the current behavior without causing any breaking changes.
Footnotes
https://github.com/kubernetes/enhancements/issues/1591 ↩
https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/1591-daemonset-surge#implementation-detailsnotesconstraints ↩