feat(helm): make KUBENURSE_INSECURE configurable (#51)

chore: update readme
postfinance · Oct 25, 2022 · 4d4dc39 · 4d4dc39
1 parent 8b896f4
commit 4d4dc39
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -39,7 +39,8 @@ The following command can be used to install kubenurse with Helm: `helm upgrade
 | service.labels | Additional labels to be added to the Service | 
 | ingress.enabled                  | Enable/ Disable the ingress                                                                         | true                        |
 | ingress.className                | The classname of the ingress controller (e.g. the nginx ingress controller)                         | nginx                       |
-| ingress.url                      | The url of the ingress; e.g. kubenurse.westeurope.cloudapp.example.com                              | dummy-kubenurse.example.com |
+| ingress.url                      | The url of the ingress; e.g. kubenurse.westeurope.cloudapp.example.com                              | dummy-kubenurse.example.com | 
+| insecure                         | Control whether the http client verifies the ingress certificate (by default no verification)       | true                        |
 | rbac.allow_unschedulable.enabled | Configure a clusterrole and clusterrolebinding if env KUBENURSE_ALLOW_UNSCHEDULABLE is set to false | false                       |
 
 

diff --git a/helm/kubenurse/templates/daemonset.yaml b/helm/kubenurse/templates/daemonset.yaml
@@ -45,7 +45,7 @@ spec:
         - name: KUBENURSE_SERVICE_URL
           value: "http://kubenurse.{{ .Values.namespace }}.svc.cluster.local:{{ .Values.service.port }}"
         - name: KUBENURSE_INSECURE
-          value: "true"
+          value: {{ .Values.insecure  | quote }}
         - name: KUBENURSE_ALLOW_UNSCHEDULABLE
           value: "false"
         - name: KUBENURSE_NAMESPACE

diff --git a/helm/kubenurse/values.yaml b/helm/kubenurse/values.yaml
@@ -22,6 +22,8 @@ serviceMonitor:
   enabled: false
   labels: {}
 
+insecure: true
+
 namespace: kube-system
 
 serviceAccount: