fix: node end offset location #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the offset of specific sass ast nodes mentioned in this issue.
I had to upgrade the dev dependencies of both
postcssandpostcss-parser-teststo make this work. And also set the minimalpostcssversion from"^8.4.19"to"^8.4.29".Upgrading the
post-parser-testsalso required a small change in the test that used it since it changedjsonifyfrom returning string to object.The actual fix changed the offset in 3 places, but I only added tests for 2 cases, since I couldn't figure out what syntax can result in the parser reaching the 3rd offset.