ensure that media params remain string values #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainmenke
commented
Feb 9, 2024
Comment on lines
-9
to
-21
| function split(params, start) { | ||
| const list = [] | ||
| const last = params.reduce((item, node, index) => { | ||
| if (index < start) return "" | ||
| if (node.type === "div" && node.value === ",") { | ||
| list.push(item) | ||
| return "" | ||
| } | ||
| return item + stringify(node) | ||
| }, "") | ||
| list.push(last) | ||
| return list | ||
| } |
There was a problem hiding this comment.
I overlooked that this was still present and JavaScript automatically joins arrays of strings with ,.
This entire section has become redundant with the refactors for v16.
romainmenke
force-pushed
the
fix-557--intuitive-akita-caa1b56c5d
branch
from
62dae71
to
2d1301c
Compare
|
Thank you for reviewing @RyanZim 🙇 I've added a separate plugin that always runs after It tests a few more things than just |
RyanZim
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes : #557