Add typings #1382
Add typings #1382
Conversation
package.json
Outdated
| "no-unused-vars": "off" | ||
| "no-unused-vars": "off", | ||
| "no-redeclare": "off", | ||
| "@typescript-eslint/no-redeclare": ["error"] |
There was a problem hiding this comment.
| "@typescript-eslint/no-redeclare": ["error"] | |
| "@typescript-eslint/no-redeclare": "error" |
There was a problem hiding this comment.
What error it prevents in Autoprefixer?
There was a problem hiding this comment.
no-redeclare rule forbid to make function overloading. Maybe it is better to move rules to @logux/eslint-config:
"no-redeclare": "off",
"@typescript-eslint/no-redeclare": "error"
There was a problem hiding this comment.
In any place when you will have function overloading or interface declaration merging. no-redeclare doesn't understand that it is not "redeclare", @typescript-eslint/no-redeclare handles these cases.
There was a problem hiding this comment.
Thanks for the suggestion. I released ESLint config 44.0.1 and updated config in Autoprefixer’s master.
Can you revert config changes and rebase branch (and we are ready for the release)?
|
Released in 10.2 |
Add typings based on typings from DefinitelyTyped.