Fix check for secure socket in SMTP extensions (Fixes #1336) #1338
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the check if the SMTP connection uses a secure socket. Before it directly checks the
socket
field, however this is actually anInternetMessageIO
object which inherits fromBufferedIO
, so you need to access theio
field fromBufferedIO
to actually access the 'real' SSL socket.This also means we finally see the padlock next to the sent status!
Before:
After:
This fixes #1336