Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check for secure socket in SMTP extensions (Fixes #1336) #1338

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

Jimver
Copy link
Contributor

@Jimver Jimver commented Apr 7, 2021

This PR fixes the check if the SMTP connection uses a secure socket. Before it directly checks the socket field, however this is actually an InternetMessageIO object which inherits from BufferedIO, so you need to access the io field from BufferedIO to actually access the 'real' SSL socket.

This also means we finally see the padlock next to the sent status!

Before:
Screenshot 2021-04-07 001322

After:
Screenshot 2021-04-08 003606

This fixes #1336

@adamcooke adamcooke merged commit 73870d6 into postalserver:master Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outgoing mail not sent over secure connection
3 participants