Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

square images url, not resized proportional #332

Merged
merged 2 commits into from
Apr 23, 2018
Merged

square images url, not resized proportional #332

merged 2 commits into from
Apr 23, 2018

Conversation

rhcarlosweb
Copy link
Contributor

@rhcarlosweb
Copy link
Contributor Author

but this getSquareThumbnailsUrl is a new functions i have created a time ago, but someone change to display_src in another commit #329

@bomboem
Copy link

bomboem commented Apr 13, 2018

Is there a way in the current state to get the square images, without removing the option to get the proportional images?

@rhcarlosweb
Copy link
Contributor Author

rhcarlosweb commented Apr 13, 2018

But on the line 451~462 it's the proportionals images, and this proportionals images is passed to
imageThumbnailUrl
imageLowResolutionUrl
imageStandardResolutionUrl

And square images it's passed to getSquareImages

@bomboem
Copy link

bomboem commented Apr 13, 2018

Allright, thank you for pointing this out :)

@raiym raiym merged commit 7afc32b into postaddictme:master Apr 23, 2018
@raiym
Copy link
Member

raiym commented Apr 23, 2018

@rhcarlosweb thank you for contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants