Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imageurl fix #2

Merged
merged 3 commits into from
May 13, 2016
Merged

Imageurl fix #2

merged 3 commits into from
May 13, 2016

Conversation

wrinkleydog
Copy link
Contributor

Build image urls when GetMediaByUrl is called.

@raiym
Copy link
Member

raiym commented May 13, 2016 •
edited
Loading

@wrinkleydog thank you very much!

Just comment: In first commit in fromMediaPage() you deleted ['text'] and it seems right but in second commit you checking that caption is presented and again you added ['text'].

I have checked and it seems that deleting ['text'] was right thing or you added it again on purpose?

@wrinkleydog
Copy link
Contributor Author

Good catch!

Deleting ['text'] is the correct one.

On Fri, May 13, 2016 at 10:06 AM, Raiymbek Kapishev <
[email protected]> wrote:

@wrinkleydog https://github.com/wrinkleydog thank you very much!

Just comment: In first commit in fromMediaPage() you deleted ['text'] and
it seems right but in second commit you checking that caption is presented
and again you added ['text'].

I have checked and it seems that deleting ['text'] was right thing or you
added ['text'] on purpose?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#2 (comment)

@raiym
Copy link
Member

raiym commented May 13, 2016

Okay!

@raiym raiym merged commit bdb3f91 into postaddictme:master May 13, 2016
@borysov borysov mentioned this pull request Nov 2, 2016
Closed
@hasandahsin hasandahsin mentioned this pull request Feb 21, 2017
Closed
@sfatfarma sfatfarma mentioned this pull request Mar 22, 2017
Closed
@ximrx ximrx mentioned this pull request Apr 18, 2017
Closed
raiym pushed a commit that referenced this pull request Oct 17, 2017
@adam-szabo
Merge pull request #2 from adam-szabo/feature/get-followers
993a9ee 
Get followers
@amauryleproux amauryleproux mentioned this pull request Oct 21, 2017
Closed
@istorepro istorepro mentioned this pull request Jan 24, 2018
Closed
@raaaas raaaas mentioned this pull request Mar 3, 2018
Closed
raiym pushed a commit that referenced this pull request May 29, 2018
@Mulkave
Merge pull request #2 from postaddictme/master
13fa13a 
Updating fork
@abondarev84 abondarev84 mentioned this pull request Jan 20, 2019
Closed
@bengrzybowski bengrzybowski mentioned this pull request Mar 15, 2020
Closed
@fadedreams fadedreams mentioned this pull request Mar 23, 2020
Closed
@kvrushifa kvrushifa mentioned this pull request Jun 29, 2020
Closed
@zubairsultan786 zubairsultan786 mentioned this pull request Aug 25, 2020
Merged
raiym pushed a commit that referenced this pull request Aug 26, 2020
@congkv
Merge pull request #2 from congkv/feature/add_function_to_scrap_all_f…
538fe19 
…ollowers

Add getPaginateAllFollowers() function
@janKossin janKossin mentioned this pull request Sep 1, 2020
Closed
@arashnz arashnz mentioned this pull request Sep 26, 2020
Closed
@alabamaster alabamaster mentioned this pull request Nov 9, 2020
Closed
@iFrez iFrez mentioned this pull request Nov 12, 2020
Closed
@thedevale thedevale mentioned this pull request Feb 27, 2021
Closed
sergoslav added a commit to sergoslav/instagram-php-scraper that referenced this pull request Sep 14, 2021
@sergoslav
catch TooManyRquests error postaddictme#2
e807fe5
@smartali89 smartali89 mentioned this pull request Jan 6, 2022
Closed
@MohammadZarifiyan MohammadZarifiyan mentioned this pull request Mar 12, 2022
Closed
@thatcoolguy thatcoolguy mentioned this pull request Oct 17, 2022
Closed
@spapapan spapapan mentioned this pull request Jan 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wrinkleydog @raiym