Multiples fixes: #194
Merged
Multiples fixes: #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Geolim4
commented
Nov 4, 2017
Geolim4
commented
- Replaced self class calls by static keyword (allows better class extending)
- Enforced strict comparisons on string
- Safely replaced some double quotes by simple quotes
- Replaced self class call by static (allows better extending) - Enforced strict comparisons on string - Safely replaced some double quotes by simple quotes
|
Dear @Geolim4 thank you for your contribution. |
|
oO |
|
Ahhh okay... |
|
@Geolim4 thank you |
|
Your changes were merged to my Pr :) |
|
@Geolim4 thank you for contribution |
|
You're welcome ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.