Skip to content

fix(modal): for apply changes need run changeDetection (#UIM-348) #394

Merged
merged 1 commit into from
Jan 24, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/mosaic/modal/modal.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ type AnimationState = 'enter' | 'leave' | null;
selector: 'mc-modal',
templateUrl: './modal.component.html',
styleUrls: ['./modal.css'],
changeDetection: ChangeDetectionStrategy.OnPush,
encapsulation: ViewEncapsulation.None,
host: {
'(keydown)': 'onKeyDown($event)'
Expand Down Expand Up @@ -120,7 +119,7 @@ export class McModalComponent<T = any, R = any> extends McModalRef<T, R>
@Input() @Output() mcOnCancel: EventEmitter<T> | OnClickCallback<T> = new EventEmitter<T>();

@ViewChild('modalContainer', { static: true }) modalContainer: ElementRef;
@ViewChild('bodyContainer', { read: ViewContainerRef, static: false}) bodyContainer: ViewContainerRef;
@ViewChild('bodyContainer', { read: ViewContainerRef, static: false }) bodyContainer: ViewContainerRef;
// Only aim to focus the ok button that needs to be auto focused
@ViewChildren('autoFocusedButton', { read: ElementRef }) autoFocusedButtons: QueryList<ElementRef>;

Expand Down Expand Up @@ -168,7 +167,6 @@ export class McModalComponent<T = any, R = any> extends McModalRef<T, R>
private changeDetector: ChangeDetectorRef,
@Inject(DOCUMENT) private document: any
) {

super();
}

Expand Down