chore(common): setting properties with set and get to private #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting most of properties with set and get to private. Some, like in packages/cdk/tree/padding.ts are keeped as they were to avoid breaking changes.
Margar1ta
changed the title
Margar1ta
changed the title
lskramarov
approved these changes
Oct 24, 2019
pimenovoleg
approved these changes
Oct 24, 2019
pimenovoleg
pushed a commit
that referenced
this pull request
Oct 25, 2019
* chore(common): setting properties with set and get to private Setting most of properties with set and get to private. Some, like in packages/cdk/tree/padding.ts are keeped as they were to avoid breaking changes. * chore(tags): setting _tabIndex to public
pimenovoleg
pushed a commit
that referenced
this pull request
Oct 25, 2019
* chore(common): setting properties with set and get to private Setting most of properties with set and get to private. Some, like in packages/cdk/tree/padding.ts are keeped as they were to avoid breaking changes. * chore(tags): setting _tabIndex to public
roll314
pushed a commit
to roll314/mosaic
that referenced
this pull request
Nov 7, 2019
…ve-js#315) * chore(common): setting properties with set and get to private Setting most of properties with set and get to private. Some, like in packages/cdk/tree/padding.ts are keeped as they were to avoid breaking changes. * chore(tags): setting _tabIndex to public
Margar1ta
deleted the
feature/UIM-179_tslint_not_private_with_get_set
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting most of the properties with set and get to private.
Some, like in packages/cdk/tree/padding.ts are keeping as they were to avoid breaking changes.