feat(tree): added description for getValue and getViewValue, also added compareValues and compareViewValues (#UIM-174) #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed compareValues and compareViewValues (#UIM-174)
pimenovoleg
approved these changes
Oct 18, 2019
| public getViewValue: (dataNode) => string, | ||
| /** compareValues will be used to comparing values. */ | ||
| public compareValues: (firstValue, secondValue) => boolean = defaultCompareValues, | ||
| /** compareValues will be used to comparing values. */ |
There was a problem hiding this comment.
Копипаст во втором комментарии, тут должно быть про compareViewValues.
И непонятна разница между ними... Думаю стоит дописать, для чего нужно сравнение значений.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.