fix(modal): for apply changes need run changeDetection (#UIM-348) #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview docs changes for 659c5f2 at https://positive-js.github.io/mosaic-previews/pr394-659c5f2/ |
Это можно исправить оставив onPush, давай это сделаем в другом PR. Не критично, если сейчас переключим стратегию на default. |
pimenovoleg
approved these changes
Jan 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Поковырял то что есть и пришел к выводу, что пока проще всего отключить ChangeDetectionStrategy.OnPush в McModalComponent.
@fost посмотри, возможно Я не совсем понял реализацию и есть другой вариант решения этой проблемы.