fix(tags): fixed error "Expression has changed after it was checked" …

…(#UIM-376) (#432) 8x
positive-js · Mar 13, 2020 · 7cb3f34 · 7cb3f34
1 parent e1b3971
commit 7cb3f34
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/packages/mosaic-dev/validation/template.html b/packages/mosaic-dev/validation/template.html
@@ -60,6 +60,10 @@
             </mc-tag-list>
         </mc-form-field>
 
+        <div class="mc-form-field_error" *ngIf="reactiveForm.controls.reactiveTypeaheadValue.errors">
+            <div *ngIf="reactiveForm.controls.reactiveTypeaheadValue.errors?.required">error</div>
+        </div>
+
         <br><br>
 
         <button mc-button>Submit</button>
@@ -69,7 +73,6 @@
         </div>
     </form>
 
-
     <br><br>
 
     <form class="margin" #form="ngForm" (ngSubmit)="onSubmitTemplateForm(form)" novalidate>
@@ -139,6 +142,7 @@
             </mc-tag-list>
         </mc-form-field>
 
+
         <br>
         <br>
 
@@ -166,6 +170,10 @@
         <br><br>
 
         <button mc-button>Submit</button>
+
+        <div class="mc-form-field_error" *ngIf="formWithCustomValidator.controls.login.errors">
+            <div *ngIf="formWithCustomValidator.controls.login.errors?.required">error</div>
+        </div>
     </form>
 
     <div class="margin">

diff --git a/packages/mosaic/tags/tag-list.component.ts b/packages/mosaic/tags/tag-list.component.ts
@@ -417,13 +417,9 @@ export class McTagList extends McTagListMixinBase implements McFormFieldControl<
                 // has changed after it was checked" errors from Angular.
                 Promise.resolve().then(() => {
                     this.tagChanges.emit(this.tags.toArray());
-
-                    this.changeDetectorRef.markForCheck();
+                    this.stateChanges.next();
+                    this.propagateTagsChanges();
                 });
-
-                this.stateChanges.next();
-
-                this.propagateTagsChanges();
             });
     }