default to HTML file proxy unless uri is http or https (#4939) #4945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Addresses #4930 On Windows, a file path has scheme `C`, which was not handled in #4855. I had assumed local file paths would all have scheme `file`, but that is not the case on Windows! I've updated the logic to start a generic HTTP proxy server when the scheme is `http` or `https`, but to assume all other paths are HTML file paths. The behaviour of `startHtmlProxyServer` before #4855 was to always start an HTML proxy server, so this PR restores that assumption by always starting an HTML proxy server unless we have an `http`/`https` URL (in which case we want to start a generic proxy server). ### QA Notes See #4930 for repro notes. Co-authored-by: sharon wang <[email protected]>
jmcphers
approved these changes
Oct 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the fix for #4930 to the
2024.10release by cherry-picking the commit from #4939.