always send html plot content to a proxy server #4876
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A follow-up to #4806 to revert
src/vs/workbench/services/languageRuntime/common/languageRuntimeUiClient.ts
back to using a proxy for interactive plots. A generic HTTP proxy was added via #4855, so server plots can be proxied appropriately in Server Web and Workbench.Related to
QA Notes
On Server Web and Workbench, running the following in the corresponding consoles:
Python
pip install plotly nbformat pandas
R
install.packages('plotly')
Expected Result
The corresponding interactive plots should display in the plots pane and be interact-able!