docs: update streamlit example and readmes #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbkegley
changed the title
dbkegley
changed the title
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
jonkeane
reviewed
Mar 6, 2024
| certifi==2024.2.2 | ||
| charset-normalizer==3.3.2 | ||
| click==8.1.7 | ||
| databricks-sql-connector==3.0.1 |
There was a problem hiding this comment.
This is more a question than an issue or suggestion: what happened with all of these dependencies? Were they old copy 🍝 or something?
There was a problem hiding this comment.
I did a pip freeze initially on this example but I like the approach that @plascaray used in his examples better where we only capture the dependencies that we really need, and then let pip handle transitive deps. No need for us to record them here IMO so I was cleaning this up so that it's consistent with the other examples
jonkeane
reviewed
Mar 6, 2024
Comment on lines
-31
to
-32
| cfg = Config(host=DB_HOST_URL, credentials_provider=credentials_provider) | ||
| # cfg = Config(host=DB_HOST_URL, token=DB_PAT) |
There was a problem hiding this comment.
❤️ 🧹 #️⃣
Thank for cleaning this up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the streamlit example consistent with our other examples
I'm also going to update the other PRs to talk about the required environment vars before running the apps locally