Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Added Shiny for Python example #74

Merged
merged 12 commits into from
Mar 5, 2024
Merged

Conversation

plascaray
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Mar 5, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
282 246 87% 80% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 04bf5f6 by action🐍

@plascaray plascaray changed the title Added Shiny for Python example docs: Added Shiny for Python example Mar 5, 2024
@plascaray plascaray requested review from dbkegley and zackverham March 5, 2024 17:00
examples/connect/shiny-python/README.md Show resolved Hide resolved
examples/connect/shiny-python/README.md Outdated Show resolved Hide resolved
examples/connect/shiny-python/README.md Outdated Show resolved Hide resolved
examples/connect/shiny-python/app.py Outdated Show resolved Hide resolved
examples/connect/shiny-python/app.py Outdated Show resolved Hide resolved
examples/connect/shiny-python/app.py Outdated Show resolved Hide resolved
@dbkegley
Copy link
Collaborator

dbkegley commented Mar 5, 2024

Left a few comments for things we might refactor, mainly around the use of the PAT, but nothing major. This looks really close, thanks @plascaray !

@plascaray plascaray requested a review from dbkegley March 5, 2024 21:54
Copy link
Collaborator

@dbkegley dbkegley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks again @plascaray !

@plascaray plascaray merged commit 916248c into main Mar 5, 2024
8 checks passed
@plascaray plascaray deleted the pbl-examples-shiny-for-python branch March 5, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants