Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updates README and adds CODE_OF_CONDUCT #68

Merged
merged 6 commits into from
Mar 4, 2024
Merged

Conversation

tdstein
Copy link
Collaborator

@tdstein tdstein commented Mar 4, 2024

Copy link

github-actions bot commented Mar 4, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
544 508 93% 80% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 72d2bdf by action🐍

@@ -0,0 +1,127 @@
# Contributor Covenant Code of Conduct
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For our future reference: the original source of this is https://github.com/r-lib/usethis/blob/main/inst/templates/CODE_OF_CONDUCT.md

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@@ -10,22 +10,20 @@ Before contributing to the `posit-sdk`, ensure that the following prerequisites

- Python >=3.8

## Instructions
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you confirmed that these instructions work?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am running some tests to validate things work as expected on a forked repository.

tdstein and others added 2 commits March 4, 2024 13:45
Co-authored-by: Neal Richardson <[email protected]>
Co-authored-by: Neal Richardson <[email protected]>
@tdstein tdstein changed the title chore: updates README and adds CODE_OF_CONDUCT updates README and adds CODE_OF_CONDUCT Mar 4, 2024
@tdstein tdstein changed the title updates README and adds CODE_OF_CONDUCT chore: updates README and adds CODE_OF_CONDUCT Mar 4, 2024
@tdstein tdstein merged commit fe0e95d into main Mar 4, 2024
11 of 13 checks passed
@tdstein tdstein deleted the tdstein/instructions branch March 4, 2024 21:43
@@ -10,22 +10,20 @@ Before contributing to the `posit-sdk`, ensure that the following prerequisites

- Python >=3.8

## Instructions

1. Fork the repository and clone it to your local machine.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this imply that all PRs should come from forks moving forward? Less a question about the correctness of this stance, more want to make sure @dbkegley and I follow the expected pattern as we're working on things.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good call out! For posit-dev members, direct pull requests are welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants