-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: updates README and adds CODE_OF_CONDUCT #68
Conversation
tdstein
commented
Mar 4, 2024
- chore: updates README with additional instructions
- chore: adds CODE_OF_CONDUCT copied from https://github.com/posit-dev/great-tables/blob/main/CODE_OF_CONDUCT.md
- chore: updates README
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
@@ -0,0 +1,127 @@ | |||
# Contributor Covenant Code of Conduct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For our future reference: the original source of this is https://github.com/r-lib/usethis/blob/main/inst/templates/CODE_OF_CONDUCT.md
@@ -10,22 +10,20 @@ Before contributing to the `posit-sdk`, ensure that the following prerequisites | |||
|
|||
- Python >=3.8 | |||
|
|||
## Instructions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you confirmed that these instructions work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am running some tests to validate things work as expected on a forked repository.
Co-authored-by: Neal Richardson <[email protected]>
Co-authored-by: Neal Richardson <[email protected]>
@@ -10,22 +10,20 @@ Before contributing to the `posit-sdk`, ensure that the following prerequisites | |||
|
|||
- Python >=3.8 | |||
|
|||
## Instructions | |||
|
|||
1. Fork the repository and clone it to your local machine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this imply that all PRs should come from forks moving forward? Less a question about the correctness of this stance, more want to make sure @dbkegley and I follow the expected pattern as we're working on things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good call out! For posit-dev members, direct pull requests are welcome!