Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Tag.update() -> Tag method #351

Merged
merged 2 commits into from
Dec 9, 2024
Merged

feat: Add Tag.update() -> Tag method #351

merged 2 commits into from
Dec 9, 2024

Conversation

schloerke
Copy link
Collaborator

Fixes #350

Missed method in #346 . Discovered from #162 top comment

@schloerke schloerke self-assigned this Dec 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
2131 1982 93% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/posit/connect/tags.py 96% 🟢
TOTAL 96% 🟢

updated for commit: 62d6b37 by action🐍

@schloerke schloerke marked this pull request as ready for review December 9, 2024 18:18
@schloerke schloerke requested a review from tdstein as a code owner December 9, 2024 18:18
tdstein
tdstein reviewed Dec 9, 2024
View reviewed changes
src/posit/connect/tags.py Outdated Show resolved Hide resolved
tdstein
tdstein reviewed Dec 9, 2024
View reviewed changes
src/posit/connect/tags.py Outdated Show resolved Hide resolved
@schloerke schloerke added enhancement New feature or request sdk Used for automation labels Dec 9, 2024
tdstein
tdstein approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@tdstein tdstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for rearranging the conditional logic!

@schloerke schloerke merged commit e8392e0 into main Dec 9, 2024
35 checks passed
@schloerke schloerke deleted the schloerke/tag-delete branch December 9, 2024 21:45
@tdstein tdstein mentioned this pull request Dec 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdstein tdstein tdstein approved these changes

Assignees

@schloerke schloerke

Labels
enhancement New feature or request sdk Used for automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Add tag.update() support
2 participants
@schloerke @tdstein