feat: always resolve content owner #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
| @@ -37,7 +37,13 @@ | |||
| "default_py_environment_management": null, | |||
| "run_as": null, | |||
| "run_as_current_user": false, | |||
| "owner_guid": "87c12c08-11cd-4de1-8da3-12a7579c4998", | |||
| "owner_guid": "20a79ce3-6e87-4522-9faf-be24228800a4", | |||
| "owner": { | |||
There was a problem hiding this comment.
I would back this change out. The API wouldn't return owner in this request.
Co-authored-by: Neal Richardson <[email protected]>
nealrichardson
approved these changes
Jun 13, 2024
| c = Client("12345", "https://connect.example") | ||
| item = c.content.get("f2f37341-e21d-3d80-c698-a935ad614066") | ||
| owner = item.owner | ||
| assert owner.guid == "20a79ce3-6e87-4522-9faf-be24228800a4" |
There was a problem hiding this comment.
Other things to assert:
- owner is ContentItemOwner (if we care about that)
- The user GET on L201 was called once
- Do item.owner again and confirm that L201 has still only been called once.
There was a problem hiding this comment.
Good call. Done. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #165