feat: adds usage #166
Merged
feat: adds usage #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
jonkeane
reviewed
Apr 11, 2024
| def find( | ||
| self, | ||
| content_guid: str = ..., | ||
| min_data_version: int = ..., |
There was a problem hiding this comment.
Do you have a test for something other than the default for min_data_version? Something that is a bit funny is that though the parameter is the same, for shiny the default (and max) is 1, for not-shiny content the default (and max) is 3
There was a problem hiding this comment.
These arguments are passed through as query parameters to the server, which performs all validation. If the server responds with a failure, then a ClientError is raised.
>>> from posit import connect
>>> c = connect.Client()
>>> event = c.usage.find_one(min_data_version=-1)
Traceback (most recent call last):
...
posit.connect.errors.ClientError: The parameter min_data_version=-1 is less than the allowed minimum 0 (Error Code: 25, HTTP Status: 400 Bad Request)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more or less a copy of the
visitsimplementation.I am considering the best way to facade these resources behind a single interface. See #167