feat: adds bundles #161
feat: adds bundles #161
Conversation
Adds support for bundles.find, bundles.find_one, bundles.get, and bundle.delete.
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
| from .resources import Resources, Resource | ||
|
|
||
|
|
||
| class BundleMetadata(Resource): |
There was a problem hiding this comment.
Does this need to be a Class? It's not a Resource properly, is it? There's nothing you can do with it. It just feels like a nested field in Bundle to me, Bundle.metadata is a dict.
There was a problem hiding this comment.
I'm considering this a continuation of the pattern of using @property methods for fields to support compatibility between server versions.
| for result in results | ||
| ] | ||
|
|
||
| def find_one(self) -> Bundle | None: |
There was a problem hiding this comment.
find_one() is pretty pointless without any args or query params, no?
There was a problem hiding this comment.
We have defined find and fine_one in each of the Resources classes thus far, it seems ok to continue that pattern. I'm still up for adding fetch and fetch_one in place of find and find_one when there aren't any supported query params for the endpoint.
Adds support for bundles.find, bundles.find_one, bundles.get, and bundle.delete.
Resolves #109