Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: reduces config complexity #13

Merged
merged 3 commits into from
Feb 7, 2024
Merged

refactor: reduces config complexity #13

merged 3 commits into from
Feb 7, 2024

Conversation

tdstein
Copy link
Collaborator

@tdstein tdstein commented Feb 5, 2024

Removes the implementation in config.py and moves essential logic to client.py. A Config class isn't needed at this time.

nealrichardson
nealrichardson reviewed Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions but generally LGTM

src/posit/connect/client.py Outdated Show resolved Hide resolved
src/posit/connect/client.py Outdated Show resolved Hide resolved
tdstein and others added 2 commits February 6, 2024 13:24
@tdstein tdstein merged commit 532cdce into main Feb 7, 2024
5 checks passed
@nealrichardson nealrichardson deleted the tdstein/remove-config branch February 16, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nealrichardson nealrichardson nealrichardson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdstein @nealrichardson