-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds update support to content #120
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach looks interesting to me. It preserves typchecking/hints to the extent possible while allowing for forward compatibility (I was assuming that's a design goal; if not then we can reconsider).
Thanks! Here's another behavioral artifact that I find interesting. You can define additional overload methods, and the language server will navigate those type hints correctly. So, the method signature effectively becomes the request schema for different API versions. Screen.Recording.2024-03-22.at.12.49.17.mov |
Resolves #89
Here's a recording that demonstrates the type hinting behavior in VSCode.
Screen.Recording.2024-03-22.at.10.20.48.mov