Skip to content

Commit

Permalink
refactor: revert to typing-extensions library (#333)
Browse files Browse the repository at this point in the history
Revert to using the typing-extensions package since it performs the same
logic introduced in the `_typing_extensions.py` module copied from
Shiny. For example, here is the `Self` implementation in
typing-extensions, which keys off of the python version to determine the
correct import.
https://github.com/python/typing_extensions/blob/main/src/typing_extensions.py#L2229-L2247
  • Loading branch information
tdstein authored Nov 12, 2024
1 parent 4edb9f1 commit 540c693
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 47 deletions.
42 changes: 0 additions & 42 deletions src/posit/connect/_typing_extensions.py

This file was deleted.

3 changes: 2 additions & 1 deletion src/posit/connect/content.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,10 @@
overload,
)

from typing_extensions import NotRequired, Required, TypedDict, Unpack

from . import tasks
from ._api import ApiDictEndpoint, JsonifiableDict
from ._typing_extensions import NotRequired, Required, TypedDict, Unpack
from .bundles import Bundles
from .context import Context
from .env import EnvVars
Expand Down
3 changes: 2 additions & 1 deletion src/posit/connect/jobs.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import posixpath
from typing import Any, Literal, Optional, overload

from ._typing_extensions import NotRequired, Required, TypedDict, Unpack
from typing_extensions import NotRequired, Required, TypedDict, Unpack

from .context import Context
from .resources import Active, ActiveFinderMethods, ActiveSequence, Resource

Expand Down
3 changes: 2 additions & 1 deletion src/posit/connect/oauth/oauth.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@

from typing import Optional

from .._typing_extensions import TypedDict
from typing_extensions import TypedDict

from ..resources import ResourceParameters, Resources
from .integrations import Integrations
from .sessions import Sessions
Expand Down
3 changes: 2 additions & 1 deletion src/posit/connect/users.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@

from typing import List, Literal

from typing_extensions import NotRequired, Required, TypedDict, Unpack

from . import me
from ._typing_extensions import NotRequired, Required, TypedDict, Unpack
from .content import Content
from .paginator import Paginator
from .resources import Resource, ResourceParameters, Resources
Expand Down
3 changes: 2 additions & 1 deletion src/posit/connect/vanities.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from typing import Callable, List, Optional

from ._typing_extensions import NotRequired, Required, TypedDict, Unpack
from typing_extensions import NotRequired, Required, TypedDict, Unpack

from .errors import ClientError
from .resources import Resource, ResourceParameters, Resources

Expand Down

0 comments on commit 540c693

Please sign in to comment.