Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql-migrate does not support go modules is broken by v2 change #107

Closed
drscre opened this issue Nov 18, 2019 · 2 comments
Closed

sql-migrate does not support go modules is broken by v2 change #107

drscre opened this issue Nov 18, 2019 · 2 comments

Comments

@drscre
Copy link

drscre commented Nov 18, 2019 •
edited
Loading

After v2 was merged directly into master (contrary to recommendations here https://blog.golang.org/v2-go-modules, section "Major version strategies"), some tools that (indirectly) rely on posener/complete and do no require module support broke.

rubenv/sql-migrate#155
@drscre drscre changed the title Releasing v2 into master broke compatibility Releasing v2 into master broke go get compatibility Nov 18, 2019
@posener posener changed the title Releasing v2 into master broke go get compatibility sql-migrate does not support go modules is broken by v2 change Nov 18, 2019
@posener
Copy link
Owner

posener commented Nov 18, 2019

Sorry about that, thanks for reporting this, continuing the conversation in the sql-migrate thread.

lukas-brenning added a commit to lukas-brenning/sql-migrate that referenced this issue Nov 20, 2019
@lukas-brenning
Add dependencies to repository
755dc5c 
rubenv#155
posener/complete#107

Posener introduced breaking changes to the `complete` repository,
`sql-migrate` depends on that repository and can therefore not be built
anymore.
Intermediate solution is to fork repo and push dependencies.
@posener
Copy link
Owner

posener commented Nov 22, 2019

Fixed by having the default branch on v1.

@posener posener closed this as completed Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drscre @posener