-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filled out .janno #22
filled out .janno #22
Conversation
Great, thanks @Kavlahkaff. I think CollectionID is a list column, so you should just put both. |
In the schema it is marked as single entry. Should I put both nonetheless or only one of them? |
I agree that it should be a list column. Let's change that with the next schema release. Could you please open a one-sentence issue about this in the schema repo, @Kavlahkaff? For the moment the column just stores a string, so I think you can add a list |
Okay, I opened an issue in the Poseidon schema repo. I will then add the values as you proposed. |
I have now added and commited the CollectionID's to the individuals where I found corresponding values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The added information looks great, BUT:
Please do NOT replace any information that was already filled by MINOTAUR (e.g. Nr_SNPs, RateX/Y etc). This is information that is dependent on the data processing, and should therefore reflect our processing, and not the author's.
Please revert the changes to those columns. The rest looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- An additional file has been committed that does not belong to this package:
2023_Ferraz_NatureEcologyEvolution/2023_Ferraz_NatureEcologyEvolution2.csv
-
2023_Salazar_MachuPicchu/2023_Salazar_MachuPicchu.janno
needs a new line at EOF.
This does not belong here
Co-authored-by: Thiseas C. Lamnidis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice @Kavlahkaff ! One last thing:
-
Tooth (molar)
in theSource_Tissue
should be replaced withtooth_molar
as per the example in the website.
b7338d9
into
poseidon-framework:2023_Salazar_MachuPicchu
Started to fill the .janno file. The CollectionId is not yet added, as I was unsure whether to use the ANTPA catalogue id or the Machu Picchu cemetery number.