Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filled out .janno #22

Conversation

Kavlahkaff
Copy link
Contributor

Started to fill the .janno file. The CollectionId is not yet added, as I was unsure whether to use the ANTPA catalogue id or the Machu Picchu cemetery number.

@stschiff
Copy link
Member

Great, thanks @Kavlahkaff. I think CollectionID is a list column, so you should just put both.

@Kavlahkaff
Copy link
Contributor Author

In the schema it is marked as single entry. Should I put both nonetheless or only one of them?

@nevrome
Copy link
Member

nevrome commented Oct 17, 2024

I agree that it should be a list column. Let's change that with the next schema release. Could you please open a one-sentence issue about this in the schema repo, @Kavlahkaff?

For the moment the column just stores a string, so I think you can add a list x;y;... without breaking anything.

@Kavlahkaff
Copy link
Contributor Author

Okay, I opened an issue in the Poseidon schema repo. I will then add the values as you proposed.

@Kavlahkaff
Copy link
Contributor Author

I have now added and commited the CollectionID's to the individuals where I found corresponding values.

Copy link
Member

@TCLamnidis TCLamnidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added information looks great, BUT:
Please do NOT replace any information that was already filled by MINOTAUR (e.g. Nr_SNPs, RateX/Y etc). This is information that is dependent on the data processing, and should therefore reflect our processing, and not the author's.

Please revert the changes to those columns. The rest looks great!

2023_Salazar_MachuPicchu/2023_Salazar_MachuPicchu.janno Outdated Show resolved Hide resolved
Copy link
Member

@TCLamnidis TCLamnidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • An additional file has been committed that does not belong to this package: 2023_Ferraz_NatureEcologyEvolution/2023_Ferraz_NatureEcologyEvolution2.csv
  • 2023_Salazar_MachuPicchu/2023_Salazar_MachuPicchu.janno needs a new line at EOF.

2023_Salazar_MachuPicchu/2023_Salazar_MachuPicchu.janno Outdated Show resolved Hide resolved
Copy link
Member

@TCLamnidis TCLamnidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice @Kavlahkaff ! One last thing:

  • Tooth (molar) in the Source_Tissue should be replaced with tooth_molar as per the example in the website.

@TCLamnidis TCLamnidis merged commit b7338d9 into poseidon-framework:2023_Salazar_MachuPicchu Nov 28, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants