Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed some minor issues in .janno files #30

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Conversation

nevrome
Copy link
Member

@nevrome nevrome commented Sep 25, 2021

mostly trailing whitespaces in character columns

@nevrome
Copy link
Member Author

nevrome commented Sep 25, 2021

I just realized that this PR also changes the notation of some floating point numbers in the .janno files. That was not intentional, but a side effect of editing the files with Libre Office. Interesting

@stschiff
Copy link
Member

stschiff commented Oct 4, 2021

Wow, how did you find the white-space thing? And do we have a spec how to encode floating point numbers? I guess things like 1.23e-4 are OK, right?

@nevrome
Copy link
Member Author

nevrome commented Oct 4, 2021

poseidonR checks for that by default for a long time already. It only annoyed me enough now to fix it.

Do we have to specify how floating point numbers are supposed to be written? I mean: Many software tools/libraries can read both.

@nevrome
Copy link
Member Author

nevrome commented Oct 4, 2021

Hm - now that I look at the Scientific notation wiki entry I see that there are a lot of possible formats. Maybe we should be clear in the schema...

@stschiff
Copy link
Member

stschiff commented Oct 4, 2021

I think there is an official IEEE standard or something?

@nevrome
Copy link
Member Author

nevrome commented Oct 4, 2021

I opened an issue here: poseidon-framework/poseidon-schema#44
But for this particular PR I guess we can ignore the problem.

Copy link
Member

@stschiff stschiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Approved!

@nevrome nevrome merged commit ca5c4cd into master Nov 23, 2021
@nevrome nevrome deleted the trimmed_whitespaces branch November 23, 2021 11:58
@nevrome nevrome restored the trimmed_whitespaces branch January 29, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants