-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PB-8347: Fix KDMP Backup Failure in-case KDMP job removed post VB CR is updated with SnapshotID #399
Open
sgajawada-px
wants to merge
1
commit into
master
Choose a base branch
from
PB-8347
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OSS Scan Results:
Total issues: 142 |
License Evaluation Results:
Total License Issues: 17 |
sgajawada-px
requested review from
lalat-das,
prashanthpx,
siva-portworx,
px-kesavan and
pallav-px
October 18, 2024 05:24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
- Update CreateVolumeBackup to return a boolean based upon the snapshotID
- Update KopiaBackup runBackup to exit successfully in case the VB CR already holds the snapshotID
Which issue(s) this PR fixes (optional)
Closes #PB-8347
Special notes for your reviewer:
PFA of Testing Screenshots