Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
So many variables defined at the top of
templates/storage-cluster.yaml
are not necessary. Instead, defaults should be set invalues.yaml
.Regarding this piece of helm code:
It's not necessary to loop over a list, define the
$key
when it's not used, but instead we can use the with operatorSimply:
Also, having comments in a single line means that if any line is changed in
values.yaml
, the in-line comment must be re-aligned and spaced/tabbed all over again.Why not just have comments above what they're referencing?
Which issue(s) this PR fixes (optional)
Closes #
Special notes for your reviewer: