1138 starkware provider #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 17, 2021 11:54
mimafogeus2
force-pushed
the
1138-starkware-provider
branch
from
5f1c325 to
8d3e5fa
Compare
mimafogeus2
suggested changes
Mar 17, 2021
| * Demo code - logic will be moved into the widget in a later ticket | ||
| * Do we want to allow users to supply application/index/ethaddress? | ||
| * */ | ||
| getStarkKey() { |
There was a problem hiding this comment.
This is going to be added somewhere else. No reason to push it just to delete it one PR later.
| @@ -13,7 +13,8 @@ | |||
| "sourceMap": true, | |||
| "inlineSources": true, | |||
| "noUnusedLocals": true, | |||
| "strictNullChecks": true | |||
| "strictNullChecks": true, | |||
| "allowSyntheticDefaultImports": true // required for starkware-crypto BigNumber import | |||
There was a problem hiding this comment.
Is it really required?
From what I read, allowSyntheticDefaultImports allows to use import x from 'x' instead of import * as x from 'x'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a starkware provider with method stubs matching the API we're planning on exposing