Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretext:
Slock.it just released the first stable version of its blockchain client, INCUBED (IN3). INCUBED unlike Infura connects to the Ethereum Blockchain via an INcentivized Node Network which incentivises and distributes the trust on remote nodes while still keeping the bandwidth and storage requirements low. Such a client fits the requirements of wallets like portis.
New Functionality:
Normal usage(Current)
Using IN3
Code Changes:
networkAdapter
to include extra boolean parameter to handle in3 networks.New Signature:
networkAdapter(network: string | INetwork, gasRelay?: boolean, useIn3?: boolean)
changeNetwork
to include extra boolean parameter to handle in3 networks.New Signature:
changeNetwork(network: string | INetwork, gasRelay?: boolean, useIn3?: boolean)
Dependency Changes:
In3Subprovider
to the portis web3 provider engine library. See pull request 4Config Changes:
Possible Improvements: (with the help of Portis Team).
nodeUrl
is internally used in the iframe for infura communication. If we can remove this dependency of infura in the iframe and somehow relay the requests from inside of iframe to the in3 client it would make the flow much more smoother and code much more cleaner.Links: