Cope with GBX/GBP variations in quotes from Yahoo #4415
+26
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by scaling to the security currency. Closes portfolio-performance#4038
Nirus2000
added
the
! Good first pull request !
|
I've some portfolios where securities were created in GBX, matching what Yahoo historically reported in quotes. Their most recent rationalisations to GBP messed those up. Empirically, this change (on top of commit 05f09c8) fixes those if I manually delete the incorrect historical quotes, and then "Update Quotes." Rebasing to a more recent master I'm seeing build problems (but I see the same problems with master itself.) Are those expected? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scale GBX/GBP quotes to match the security currency when appropriate.
Closes #4038