Add derived data series to statements of assets chart

[buchen]

Uses DerivedDataSeries to hold a reference to the underlying data series (base) and the aspect to be shown (ClientDataSeries).

Issue: #3754
Issue: #4235
Issue: #4396

[buchen]

@mierin12, as commented in the other PR:

Based your code, I did some more refactored:

• First, I renamed the objects and types to be "derived" and "aspect" (similar to the widget on the dashboard)
• Second, the DerivedDataSeries is now an object that holds the reference to the underlying data series (base) and the aspect to be used. This way, we can re-used the (potentially) already cached data series.
• Third, I now create the data series based on the already created underlying data series.

If you have time, I would appreciate if you can have a look

[mierin12]

Hello @buchen , thanks for checking it !!
I have one comment related to your third point. Building from the availableSeries simplifies the code a lot and works very well, except for the isLine and isArea value. Those parameters are set from the baseDataSeries but should actually depend here on the Aspect itself, not the baseDataSeries. Ex : Interest should always be Bar type : "Interest : Taxonomies A" should be a Bar even if by default Taxonomy A will be a Line.

Proposition to fix it : something this way should work : a7cda52

So far my only comment. I will continue to double check.

I think the naming "Aspect : data series" is definitely an improvement for the Legend and Tooltip over "Aspect (data series)". But I am wondering if it is too much to repeat the Aspect in the subfolders of selection dialog.

In particular for Taxonomies that already have a long name.

vs

that I had in mind.
But as it is purely a UI question, as you prefer.
But it is true that it is very clear this way, in particular in case of long list of portfolio, sometimes you do not see anymore the top level Aspect folder, with my tree you do not know anymore where you are, while in your tree it is always clear.

[mierin12]

I do not know how to make code suggestion in the review but my proposition of update is an in this :
a7cda52

[mierin12]

No other comment than the one about the Line/Area settings, I think this works great !! Thanks a lot for looking into it, I think it is a super feature !

(for another feature in the future I am wondering if a similar approach could be used in the Performance Chart to use daily/weekly.. % for any series :) !!)

[buchen]

Thanks @mierin12 for reviewing!

Both comments make sense. I missed the showArea/lineChart. The labels should be fixed as well.

(for another feature in the future I am wondering if a similar approach could be used in the Performance Chart to use daily/weekly.. % for any series :) !!)

Yes!! Agree.

[buchen]

The dialog should not be uncluttered (sorry for the German screenshot, but you get the idea).

[buchen]

Also, I have updated the isLineChart and showArea settings:
https://github.com/portfolio-performance/portfolio/pull/4403/files#diff-19190310c6609557cfdcae769065451dd00475f2e667a52f180b8f8c683dc445R133-R137

[mierin12]

Perfect ! I have looked again, I do not see any issue, it looks good !