update Findependent PDF Extractor #4348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nirus2000
added
pdf
! Good first pull request !
|
Hello @fpschill So that we can validate your changes to the importer, we need so-called test cases. These are PDF debugs that are generated. If you have any questions... let's help each other and learn from each other! 💯 Regards |
|
@Nirus2000 Not sure if we will get a proper test case. Merge anyway because we have at least other test cases? I know that it increases the risk that it will break in the future. |
|
We have no Tests about this... 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated and extended PDF extractor for Findependent