Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Timeline Chart Tooltip Size #4297

Conversation

ma4nn
Copy link
Contributor

@ma4nn ma4nn commented Oct 22, 2024

This small PR prevents the timeline chart tooltip getting too wide because of the hint label on the bottom.
This avoids e.g. that the tooltip gets larger than the window on dashboards.

Before:
Bildschirmfoto 2024-10-22 um 11 59 17

After:
Bildschirmfoto 2024-10-22 um 11 59 40

Closes #2784

…es so that it does not extend the width of the tooltip
@buchen buchen merged commit ec42182 into portfolio-performance:master Oct 25, 2024
2 checks passed
@buchen
Copy link
Member

buchen commented Oct 25, 2024

Thanks! Nice trick. Will add it to my repertoire ;-)

@ma4nn ma4nn deleted the feature/improve_timeline_chart_tooltip_width branch October 25, 2024 07:41
Comment on lines 236 to 237
hint.setFont(this.resourceManager
.create(FontDescriptor.createFrom(data.getFont()).increaseHeight(-3).withStyle(SWT.ITALIC)));
Copy link
Member

@Nirus2000 Nirus2000 Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not working
Could it be that the “hint” is not working correctly?
It should be smaller and in italics, right?

@Nirus2000
Copy link
Member

@buchen @ma4nn
Could it be that the “hint” is not working correctly?
It should be smaller and in italics, right?

@mierin12
Copy link
Contributor

mierin12 commented Nov 2, 2024

Hello, @ma4nn @Nirus2000 do you have a "black tooltip" phenomenon with or without this PR ?
On Windows 11 I have it sometimes. It was already present in some cases and in some chart, but wonder if with this change is impacting it even further.

  • Kommer master (left) vs Kommer 0.71.2 (right):
leftmaste-rightlatestrelease.mp4

But even more strange:

  • Kommer 0.71.2, so without this PR: I have the blacktooltip with a specific data series:
0.71.2.and.datateries.mp4

Does this happen also for Mac ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip is cut off on the right for small diagrams
4 participants