Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to configured Coingecko API key from a paid plan #3917

Closed
wants to merge 1 commit into from

Conversation

buchen
Copy link
Member

@buchen buchen commented Apr 5, 2024

Issue: #3896

As discussed, optionally allow the user to provide an API key that
a) increases the rate limit
b) allow for more historical data

One caveat: the test API key does not work with the pro API endpoints. But just looking at the test key, I do not see an option to understand if is a test or pro API key. As the test API does not provide more data/rate limit, we simply do not support it.

@buchen buchen requested a review from Nirus2000 April 5, 2024 06:13
@Nirus2000
Copy link
Member

Hello @buchen
thx for review...

I think we should merge these translations. They are the same except that the plural has been formed, which is unnecessary. There is no input with multiple API keys.

  PrefTitleAPIKey = API Key
  PrefTitleAPIKeys = API Keys

In these translations, the semicolon should be replaced by a dot.

  PrefDescriptionCoingecko

Otherwise the rest should fit... 👍🏻
Alex

@buchen
Copy link
Member Author

buchen commented Apr 6, 2024

I think we should merge these translations.

The plural form is used for the section (all API Keys), the singular is used to enter one specific API Key.
As the plural form is already available and translated, I am not sure if there is a benefit in deleting the key.
And it is useful for a section that is about multiple API keys.

I added the singular form without the name of the product to be able to use it for more keys in the future. Right now there are "DivvyDiary API Key", and "AlphaVantage API Key", etc. That was unnecessary.

the semicolon should be replaced by a dot.

Probably the reason is that the English sentence (suggested by ChatGTP) has the semicolon and then it got into the translations. Also in German it is grammatically correct, but I agree it is rarely used. I'll fix it later and update the PR.

@buchen
Copy link
Member Author

buchen commented Apr 27, 2024

fixed translations and merged.

@buchen buchen closed this Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants