Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Credit Suisse AG PDF-Importer #3910

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Improve Credit Suisse AG PDF-Importer #3910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ...c/name/abuchen/portfolio/datatransfer/pdf/creditsuisseag/CreditSuisseAGExtractorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public void testWertpapierKauf01()
Security security = results.stream().filter(SecurityItem.class::isInstance).findFirst()
.orElseThrow(IllegalArgumentException::new).getSecurity();
assertThat(security.getIsin(), is("US46284V1017"));
assertNull(security.getWkn());
assertThat(security.getWkn(), is("26754105"));
assertNull(security.getTickerSymbol());
assertThat(security.getName(), is("Registered Shs Iron Mountain Inc"));
assertThat(security.getCurrencyCode(), is(CurrencyUnit.USD));
Expand Down Expand Up @@ -112,7 +112,7 @@ public void testWertpapierKauf02()
Security security = results.stream().filter(SecurityItem.class::isInstance).findFirst()
.orElseThrow(IllegalArgumentException::new).getSecurity();
assertThat(security.getIsin(), is("XS1055787680"));
assertNull(security.getWkn());
assertThat(security.getWkn(), is("24160639"));
assertNull(security.getTickerSymbol());
assertThat(security.getName(), is("6.25 % Fixed Rate Notes Norddeutsche"));
assertThat(security.getCurrencyCode(), is(CurrencyUnit.USD));
Expand Down Expand Up @@ -176,7 +176,7 @@ public void testWertpapierVerkauf01()
Security security = results.stream().filter(SecurityItem.class::isInstance).findFirst()
.orElseThrow(IllegalArgumentException::new).getSecurity();
assertThat(security.getIsin(), is("GB00B03MLX29"));
assertNull(security.getWkn());
assertThat(security.getWkn(), is("1987674"));
assertNull(security.getTickerSymbol());
assertThat(security.getName(), is("Akt. -A- Royal Dutch Shell PLC"));
assertThat(security.getCurrencyCode(), is(CurrencyUnit.EUR));
Expand Down Expand Up @@ -220,7 +220,7 @@ public void testWertpapierVerkauf02()
Security security = results.stream().filter(SecurityItem.class::isInstance).findFirst()
.orElseThrow(IllegalArgumentException::new).getSecurity();
assertThat(security.getIsin(), is("US88163VAD10"));
assertNull(security.getWkn());
assertThat(security.getWkn(), is("2429251"));
assertNull(security.getTickerSymbol());
assertThat(security.getName(), is("6.15 % Notes Teva Pharmaceutical Finance"));
assertThat(security.getCurrencyCode(), is(CurrencyUnit.USD));
Expand Down Expand Up @@ -283,7 +283,7 @@ public void testDividende01()
Security security = results.stream().filter(SecurityItem.class::isInstance).findFirst()
.orElseThrow(IllegalArgumentException::new).getSecurity();
assertThat(security.getIsin(), is("XS1055787680"));
assertNull(security.getWkn());
assertThat(security.getWkn(), is("24160639"));
assertNull(security.getTickerSymbol());
assertThat(security.getName(), is("6.25 % FIXED RATE NOTES NORDDEUTSCHE"));
assertThat(security.getCurrencyCode(), is(CurrencyUnit.USD));
Expand Down Expand Up @@ -326,7 +326,7 @@ public void testDividende02()
Security security = results.stream().filter(SecurityItem.class::isInstance).findFirst()
.orElseThrow(IllegalArgumentException::new).getSecurity();
assertThat(security.getIsin(), is("US46284V1017"));
assertNull(security.getWkn());
assertThat(security.getWkn(), is("26754105"));
assertNull(security.getTickerSymbol());
assertThat(security.getName(), is("REGISTERED SHS IRON MOUNTAIN INC"));
assertThat(security.getCurrencyCode(), is(CurrencyUnit.USD));
Expand Down
2 changes: 1 addition & 1 deletion name.abuchen.portfolio/src/name/abuchen/portfolio/datatransfer/pdf/BankSLMPDFExtractor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ private void addBuySellTransaction()
// @formatter:on
.section("shares") //
.find("Wir haben.*")
.match("^(?<shares>[\\.',\\d]+) .*$") //
.match("^(?<shares>[\\.'\\d]+) .*$") //
.assign((t, v) -> t.setShares(asShares(v.get("shares"))))

// @formatter:off
Expand Down
Loading
Loading