Fix and Modify Sunrise PDF-Importer #3889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://forum.portfolio-performance.info/t/pdf-import-von-sunrise/26633 https://forum.portfolio-performance.info/t/pdf-import-von-sunrise/26633/5 The Sunrise PDF importer was implemented in #3731. If the dividends and the taxes neutralize each other, then negative dividends were previously posted (EUR 0.00 minus taxes). This is incorrect, as a negative dividend is then displayed under "Payments". The transactions are now recorded separately in this case. A test case for the sale of securities does not exist. This has therefore been removed from the importer. (Validation) The test cases have been updated. Format source to standard eclipse format Improve regulare expressions Add missing currency detection Remove obsolet source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://forum.portfolio-performance.info/t/pdf-import-von-sunrise/26633
https://forum.portfolio-performance.info/t/pdf-import-von-sunrise/26633/5
The Sunrise PDF importer was implemented in #3731 by @auchri
If the dividends and the taxes neutralize each other, then negative dividends were previously posted (EUR 0.00 minus taxes). This is incorrect, as a negative dividend is then displayed under "Payments". The transactions are now recorded separately in this case.
A test case for the sale of securities does not exist. This has therefore been removed from the importer. (Validation)
The test cases have been updated.
Format source to standard eclipse format
Improve regulare expressions
Add missing currency detection
Remove obsolet source