Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSSI draw/ Level app opt #2403

Merged
merged 5 commits into from
Dec 5, 2024
Merged

Conversation

zxkmm
Copy link
Contributor

@zxkmm zxkmm commented Dec 5, 2024

  • make the peak of RSSI max val into orange color (it's the peak of RSSI max AKA red color), so should be similar color
  • make the dB from RSSIGraph has RSSI too (Level app parallel them, so need to have both on them)
  • after the Theme system, some remain Color call here should be satisfied to theme system, but won't do that in this PR.
  • the blue paint is broken somewhere but not here.

@zxkmm zxkmm marked this pull request as ready for review December 5, 2024 12:57
@zxkmm
Copy link
Contributor Author

zxkmm commented Dec 5, 2024

image
The H4m is original design. The h2 is the new design.

@gullradriel
Copy link
Member

I like it.

Copy link
Member

@gullradriel gullradriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, once the conversations are solved, let's merge it :-)

@zxkmm
Copy link
Contributor Author

zxkmm commented Dec 5, 2024

Shouldn't this be done in the "if (last_max_db != statistics.max_db) {" following block ?

ohhh ya thanks for the catch! it can save a lot

Is the set_dirty needed here ?

You are right, no need to set dirty here, sorry for my lazy code XD, was just too lazy lol.

All fixed, thanks again!

@gullradriel gullradriel merged commit ac89ca2 into portapack-mayhem:next Dec 5, 2024
3 checks passed
@zxkmm zxkmm deleted the level_rssi branch December 5, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants