Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ook remote adjustements #2365

Merged
merged 13 commits into from
Nov 18, 2024

Conversation

gullradriel
Copy link
Member

@gullradriel gullradriel commented Nov 17, 2024

Following on the excellent contribution by @sasaga , I'm proposing the following tiny modifications:

  • rename the app "OOK Remote"
  • rename the class OOKRemote* instead of ROOK*
  • rename the source dir ook_remote , source files ui_ook_remote.*
  • rename the directory for ook files OOKFILES
  • rename the extension to ".OOK" instead of ".ROOK"
  • changed Start to Send
  • added possibility to stop the Tx
  • moved a bit the GUI
  • renamed Symbols:XXXXus to BitTime:XXXXus
  • renamed S/Steps thing to BitTimeStep
  • added loaded file name info if one if loaded
  • clear loaded file name if a field is modified
  • changed too frequency field, allow save/restore/on change/on edit
  • added placeholder for button_save

Picture of the changes in app:

image

Copy link
Contributor

@zxkmm zxkmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks nice!
if you remove the swp file that maybe been mistakenly added, i'll approve

@htotoo
Copy link
Member

htotoo commented Nov 18, 2024

Please use the language helper in this too. At least for the start, stop,.browse.

Copy link
Contributor

@zxkmm zxkmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, will approve from my side and feel free to wait them to review their side.

@gullradriel
Copy link
Member Author

Please use the language helper in this too. At least for the start, stop,.browse.

Done. Also added to language file and now in use: "Set" and "Open File"

@gullradriel
Copy link
Member Author

TX start and stop is done and working

Copy link
Contributor

@sasaga sasaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like changes

@gullradriel gullradriel merged commit d31857c into portapack-mayhem:next Nov 18, 2024
3 checks passed
@gullradriel gullradriel deleted the ook-remote-adjustements branch November 18, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants