Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed fake brightness #2349

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Removed fake brightness #2349

merged 1 commit into from
Nov 8, 2024

Conversation

htotoo
Copy link
Member

@htotoo htotoo commented Nov 8, 2024

Maybe solves this: #2345

@htotoo htotoo requested a review from zxkmm November 8, 2024 07:05
zxkmm
zxkmm approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@zxkmm zxkmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks ok, didn't test, but i think it can't be wrong. So i'll approve.
it would be nice to have a test tar tho

@zxkmm zxkmm self-assigned this Nov 8, 2024
@zxkmm
Copy link
Contributor

zxkmm commented Nov 8, 2024

tested and it's good. lemme merge, thx!!!

@zxkmm zxkmm merged commit c31fef0 into portapack-mayhem:next Nov 8, 2024
3 checks passed
@htotoo htotoo deleted the nmfb branch November 10, 2024 18:14
htotoo added a commit to htotoo/portapack-mayhem that referenced this pull request Nov 11, 2024
@htotoo
Removed fake brightness (portapack-mayhem#2349)
0d57dd7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zxkmm zxkmm zxkmm approved these changes

Assignees

@zxkmm zxkmm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@htotoo @zxkmm