Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ccache option and transparent color instead of bool #2269

Merged
merged 5 commits into from
Sep 28, 2024

Conversation

zxkmm
Copy link
Contributor

@zxkmm zxkmm commented Sep 26, 2024

ccache

  • previously Speedup compilation using ccache package #1832 added ccache
  • we on discord found sometimes ccache creates issues, i removed it revert adding ccache tool #2153
  • but it sometimes useful, so this time add back and optional.
  • it's default disabled, unless you use such command:
    cmake -DUSE_CCACHE=ON ..then
    make or make -j or make -j10 etc
  • the default behavior cmake .. then make isn't changed (aka don't use ccache), so it’s safe for pipeline

transparency color for bmp

/* draw transparent, pass transparent color as arg, usage inline anonymous obj

  • portapack::display.drawBMP({100, 100}, foo_bmp, (const uint8_t[]){41, 24, 22}); // dec, out of {255, 255, 255}
  • portapack::display.drawBMP({100, 100}, foo_bmp, (const uint8_t[]){0x29, 0x18, 0x16}); //hex out of {0xFF, 0xFF, 0xFF}
  • draw transparent, pass transparent color as arg, usage pass uint8_t[] obj
  • const uint8_t c[] = {41, 24, 22}; or const uint8_t c[3] = {0x29, 0x18, 0x16};
  • portapack::display.drawBMP({100, 100}, foo_bmp, c);
  • don't draw transparent, pass nullptr as arg, usage
  • portapack::display.drawBMP({100, 100}, foo_bmp, nullptr);
  • ifyour image use RLE as transparency, pass any valid color as arg, it doesn't matter (like the modal bmp. TODO: write RLE transparency generator)
  • */

@zxkmm zxkmm marked this pull request as ready for review September 26, 2024 04:49
@zxkmm zxkmm enabled auto-merge (squash) September 26, 2024 04:51
Copy link
Member

@gullradriel gullradriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, look good to me.
We have to watch over next nightlies ;-)

@zxkmm zxkmm merged commit 419bc75 into portapack-mayhem:next Sep 28, 2024
3 checks passed
@zxkmm zxkmm deleted the ccache_opt branch October 4, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants