Skip to content

Commit

Permalink
use full_reset_and_init return value in init and reset_learned (#2393)
Browse files Browse the repository at this point in the history
* use full_reset_and_init return value in init and reset_learned

* do not uncomment status clear

---------

Co-authored-by: gullradriel <[email protected]>
  • Loading branch information
gullradriel and gullradriel authored Nov 25, 2024
1 parent d36ae88 commit 3dcfa4f
Showing 1 changed file with 6 additions and 13 deletions.
19 changes: 6 additions & 13 deletions firmware/common/i2cdev_max17055.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -202,16 +202,14 @@ bool I2cDev_MAX17055::init(uint8_t addr_) {
model = I2CDEVMDL_MAX17055;
query_interval = BATTERY_WIDGET_REFRESH_INTERVAL;
if (detect()) {
bool return_status = true;
if (needsInitialization()) {
// First-time or POR initialization
full_reset_and_init();
} else {
// Subsequent boot
partialInit();
return_status = full_reset_and_init();
}
partialInit();
// statusClear(); I am not sure if this should be here or not
return true;
partialInit(); // If you always want hibernation disabled
// statusClear(); // I am not sure if this should be here or not (Clear all bits in the Status register (0x00))
return return_status;
}
return false;
}
Expand All @@ -220,19 +218,15 @@ bool I2cDev_MAX17055::full_reset_and_init() {
if (!soft_reset()) {
return false;
}

if (!initialize_custom_parameters()) {
return false;
}

if (!load_custom_parameters()) {
return false;
}

if (!clear_por()) {
return false;
}

return true;
}

Expand Down Expand Up @@ -298,8 +292,7 @@ void I2cDev_MAX17055::partialInit() {
bool I2cDev_MAX17055::reset_learned() {
// this if for reset all the learned parameters by ic
// the full inis should do this
full_reset_and_init();
return true;
return full_reset_and_init();
}

bool I2cDev_MAX17055::detect() {
Expand Down

0 comments on commit 3dcfa4f

Please sign in to comment.