Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rake task for openid_connect / CILogon cleanup #944

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

aaronskiba
Copy link
Collaborator

Fixes #912

Changes proposed in this PR:

  • Adds a task to rake dmp_assistant_upgrade:4_2_3
    • Updates .identifier_prefix from 'http://cilogon.org/serverE/users/' to '' for the openid_connect IdentifierScheme
    • Updates the prefixed value of .value from 'http://cilogon.org/serverE/users/' to '' for some existing openid_connect-related identifiers
      • Specifically, the following identifiers are updated:
        old_prefix = 'http://cilogon.org/serverE/users/'
        identifier_scheme = IdentifierScheme.find_by!(name: 'openid_connect')
        identifiers = identifier_scheme.identifiers.where('value ~* ?', "#{old_prefix}.+cilogon.+")
  • NOTE: This PR is largely based off of the following PR: Clean/openid connect identifiers database #915

Intended to resolve this issue: #912
The following PR was used as a reference: #915

Co-Authored-By: Omar Rodriguez Arenas <[email protected]>
Copy link

github-actions bot commented Nov 4, 2024

1 Warning
⚠️ There are code changes, but no corresponding tests. Please include tests if this PR introduces any modifications in behavior. \n
Ignore this warning if the PR ONLY contains translation.io synced updates.

Generated by 🚫 Danger

Copy link
Collaborator

@lagoan lagoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good ! We just need an entry to the CHANGELOG

@aaronskiba
Copy link
Collaborator Author

All looks good ! We just need an entry to the CHANGELOG

Sounds good, thanks. I just added it. :)

Copy link
Collaborator

@lagoan lagoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaronskiba aaronskiba merged commit 344b823 into aaron/add-email-confirmation Nov 6, 2024
11 checks passed
@aaronskiba aaronskiba deleted the aaron/issues/912 branch November 6, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants