Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Test / Update SSO button Name Within Test #918

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

aaronskiba
Copy link
Collaborator

Changes proposed in this PR:

  • Fix ./spec/integration/openid_connect_sso_spec.rb:42 test
    • This test was failing because the SSO button name within the test was outdated. In order to pass, the test's button name must match the actual button name specified within app/views/shared/_sign_in_form.html.erb

The name of this button must match what is specified within `app/views/shared/_sign_in_form.html.erb`.
Copy link
Collaborator

@lagoan lagoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaronskiba aaronskiba merged commit bdbc3ac into integration Oct 3, 2024
11 checks passed
@aaronskiba aaronskiba deleted the aaron/fix-button-name-for-sso-test branch October 3, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants